Saving a Workbook in a Macro

As an example:
The following macro saves a file with the name Book1.xls on my desktop
It build the file name from the first three cells in the active workbook, as shown in the pic below

Sub Macro1()
Dim ThisFile As String, Ws1 As Worksheet
Set Ws1 = ActiveWorkbook.Worksheets.Item(1) ' First tab worksheet in active workbook
Let ThisFile = Ws1.Range("A1").Value & Ws1.Range("B1").Value & Ws1.Range("C1").Value
ActiveWorkbook.SaveAs Filename:="C:\Users\Elston\Desktop\" & ThisFile & ".xls"
End Sub


(see Figure 1 below)

Hello Bob
There are probably a few issues, but a few things are not clear form the info that you gave. So we can only give general info.

_ The main issue is probably related to what Allen Wyatt said above….
….”…. filename is the full name (including a path)…..”
I don’t know what you have in cells A1 or B1 or C1 , but the final string you end up with must have a form of like :
Path & "\" & Name & Extension
Path will look something like C:\Users\Elston\Desktop
Name would be something like Book1
Extension might be something like .xlsx

_ You need to be clear about where the macro is, and where the ranges are containing the string information. It is usually best to qualify the ranges fully to give their workbook and worksheet. Just one of many possibilities would be like
ActiveWorkbook.Worksheets.Item(1).Range("A1").Value
That last line example is referring to the first cell in the first worksheet of the active workbook. But I don’t know if that is what you are wanting

Without knowing the exact details of what you are doing, or wanting to do, it is not possible to know exactly what the problem might be

Alan Elston

I would like to have a macro that saves a file according to the values in A1&B1&C1. I found this in a search:

Sub SaveAsA1()
ThisFile = Range("A1").Value & Range("B1").Value & Range("C1").Value
ActiveWorkbook.SaveAs Filename:=ThisFile
End Sub


It does not seem to work. I use a PC, Windows 10, Office 365.
Does anyone have a suggestion?
Thank you.